Skip to content

async_hooks: don't read resource if ALS is disabled #34617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Flarna wants to merge 1 commit into from
Closed

async_hooks: don't read resource if ALS is disabled #34617

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[async_hooks] don't read resource if ALS is disabled 
Only call executionAsyncResource() in getStore() if the ALS instance is
enabled because the resource is not needed otherwise.
  • Loading branch information
@Flarna
Flarna committed Aug 3, 2020
commit c9fc86656e4e528824eca57157215b38fd9834e3
2 changes: 1 addition & 1 deletion lib/async_hooks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,8 +280,8 @@ class AsyncLocalStorage {
}

getStore() {
const resource = executionAsyncResource();
if (this.enabled) {
const resource = executionAsyncResource();
return resource[this.kResourceStore];
}
}
Expand Down