Skip to content

doc: harden policy around objections #34639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mmarchini wants to merge 5 commits into from
Closed

doc: harden policy around objections #34639

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1331fc1
doc: harden policy around objections
mmarchini Aug 5, 2020
a6e01ee
fixup! doc: harden policy around objections
mmarchini Aug 6, 2020
fceaff2
fixup! doc: harden policy around objections
mmarchini Aug 6, 2020
9d09194
fixup! doc: harden policy around objections
mmarchini Aug 6, 2020
01d8caa
fixup! doc: harden policy around objections
mmarchini Aug 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! doc: harden policy around objections 
Co-authored-by: Richard Lau <riclau@uk.ibm.com>
  • Loading branch information
@mmarchini @richardlau
mmarchini and richardlau authored Aug 6, 2020
commit 9d091941b3750eef4d2311e05df6683b78ba6431
2 changes: 1 addition & 1 deletion doc/guides/collaborator-guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ not land until all objections are satisfied. Collaborators should not block a
pull request without providing a reason. **Providing a set of actionable steps

@guybedford guybedford Aug 6, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again it might be nice to state this in the positive:

Any PR objection must include a clear reason for that objection as well as responsiveness to further discussion towards consensus. If reaching consensus is not possible...

@mmarchini mmarchini Aug 7, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The suggestion drops the recommendation to provide actionable steps, but I see your point. Let me try to rephrase this too.

alongside the objection is recommended, and the objector must be willing to
work with the pull request author to reach a consensus about the direction of
the pull reuqest**. If reaching consensus is not possible, a Collaborator may
the pull request**. If reaching consensus is not possible, a Collaborator may
escalate the issue to the TSC.

If the objection is not clear to others, another Collaborator may ask an
Expand Down