Skip to content

lib: add UNC support to url.pathToFileURL() #34743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mceachen wants to merge 2 commits into from
Closed

lib: add UNC support to url.pathToFileURL() #34743

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80d42fc
lib: add UNC support to url.pathToFileURL()
mceachen Aug 12, 2020
94a2126
Update url.js
mceachen Aug 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update url.js 
fix mistake in comment
  • Loading branch information
@mceachen
mceachen authored Aug 12, 2020
commit 94a21261927d871acc954eaedab4d95063389882
2 changes: 1 addition & 1 deletion lib/internal/url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1370,7 +1370,7 @@ const tabRegEx = /\t/g;
function encodePathChars(filepath) {
if (filepath.includes('%'))
filepath = filepath.replace(percentRegEx, '%25');
// In posix, "/" is a valid character in paths
// In posix, backslash is a valid character in paths:
if (!isWindows && filepath.includes('\\'))
filepath = filepath.replace(backslashRegEx, '%5C');
if (filepath.includes('\n'))
Expand Down