Skip to content

fs: deprecation warning on recursive rmdir #35562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iansu wants to merge 11 commits into from
Closed

fs: deprecation warning on recursive rmdir #35562

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
696d33c
fs: deprecation warning on recursive rmdir
iansu Oct 8, 2020
1457c49
Use expect warning test helper
iansu Oct 8, 2020
ee4d3da
Code review changes
iansu Oct 9, 2020
f3d67e6
Update deprecation message in tests
iansu Oct 9, 2020
968e299
Improve tests
iansu Oct 12, 2020
327e724
Update deprecation
iansu Oct 12, 2020
197b439
address review nits
Oct 13, 2020
e885bbe
chore: revert changes in test-fs-rmdir-recursive.js
Oct 13, 2020
94bb5ea
chore: address merge conflicts
Oct 13, 2020
2fd90bd
chore: address merge issues
Oct 13, 2020
5978379
Update deprecation message
iansu Oct 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: address merge conflicts
  • Loading branch information
bcoe committed Oct 13, 2020
commit 94bb5ea6cc023862006e4dffe14a05dd5298b23a
6 changes: 3 additions & 3 deletions doc/api/deprecations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2671,11 +2671,11 @@ changes:
description: Runtime deprecation.
-->

Type: Documentation-only
Type: Runtime

In future versions of Node.js, `fs.rmdir(path, { recursive: true })` will throw
on nonexistent paths, or when given a file as a target, use
`fs.rm(path, {recursive: true, force: true })` instead.
if `path` does not exist or is a file.
Use `fs.rm(path, { recursive: true, force: true })` instead.

[Legacy URL API]: url.md#url_legacy_url_api
[NIST SP 800-38D]: https://nvlpubs.nist.gov/nistpubs/Legacy/SP/nistspecialpublication800-38d.pdf
Expand Down