Skip to content

errors: eliminate all overhead for hidden calls #35644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mmomtchev wants to merge 12 commits into from
Closed

errors: eliminate all overhead for hidden calls #35644

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d03cb18
errors: eliminate all overhead for hidden calls
mmomtchev Oct 14, 2020
e0b4be9
do not impose a limit on stack traces
mmomtchev Oct 14, 2020
2dde837
errors: add a benchmark for hidestackframes
mmomtchev Oct 14, 2020
9e73b60
errors: fix the comments for hideStackFrame
mmomtchev Oct 15, 2020
242d668
errors: slights improvements for hideStackFrames
mmomtchev Oct 15, 2020
fc43106
errors: adopt reviewers remarks
mmomtchev Nov 9, 2020
07d1498
errors: remove eslint-disable after switch to primordials
mmomtchev Nov 9, 2020
960d269
error: replace hideStackFrames is not a constructor
mmomtchev Nov 24, 2020
5ba86f7
errors: remove unused variable
mmomtchev Nov 24, 2020
f7d0414
errors: rebase and merge
mmomtchev Dec 9, 2020
67b17b7
errors: comments and cosmetic changes
mmomtchev Dec 15, 2020
7c1d773
Update lib/internal/errors.js
mmomtchev Dec 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update lib/internal/errors.js 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
@mmomtchev @aduh95
mmomtchev and aduh95 authored Dec 15, 2020
commit 7c1d773fc85933beb183487eecc02490e9b47276
4 changes: 2 additions & 2 deletions lib/internal/errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@ const prepareStackTrace = (globalThis, error, trace) => {
break;
}
}
Comment thread
aduh95 marked this conversation as resolved.
// userStackTraceLimit is the user value for Error.stackTraceLimit
// It is updated at every new exception
// `userStackTraceLimit` is the user value for `Error.stackTraceLimit`,
// it is updated at every new exception in `captureLargerStackTrace`.
if (trace.length > userStackTraceLimit)
ArrayPrototypeSplice(trace, userStackTraceLimit);
}
Expand Down