Skip to content

stream: remove kludge masking RST on Windows #35946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mmomtchev wants to merge 3 commits into from
Closed

stream: remove kludge masking RST on Windows #35946

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d26439
stream: remove kludge masking RST on Windows
mmomtchev Nov 3, 2020
07219ab
http: graceful shutdown on res.end()
mmomtchev Nov 4, 2020
87baa75
libuv: Delay closing the socket when read is pending
mmomtchev Nov 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
http: graceful shutdown on res.end() 
On Windows and OSX, the HTTP server will often make
the OS send a TCP RST packet by shutting down the
socket before all incoming data has been read.
Normally, libuv should take care of this (?), but it does
not on Windows and OSX

Refs: #35904
  • Loading branch information
@mmomtchev
mmomtchev committed Nov 4, 2020
commit 07219ab2f544ae10417dbc6f377129bbbf39d704
5 changes: 4 additions & 1 deletion lib/_http_server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -815,7 +815,10 @@ function resOnFinish(req, res, socket, state, server) {

if (res._last) {
if (typeof socket.destroySoon === 'function') {
socket.destroySoon();
if (socket.readableEnded)
socket.destroySoon();
else
socket.on('end', socket.destroySoon);
} else {
socket.end();
}
Expand Down
5 changes: 1 addition & 4 deletions test/parallel/test-https-truncate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,8 @@ function httpsTest() {

server.listen(0, function() {
const opts = { port: this.address().port, rejectUnauthorized: false };
https.get(opts).on('response', function(res) {
https.get(opts).on('response', function (res) {
test(res);
}).on('error', () => {
// TODO: investigate why the server closes with a TCP RST on Windows
// https://github.com/nodejs/node/issues/35904
});
});
}
Expand Down