Skip to content

http2: add support for TypedArray to getUnpackedSettings #36141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aduh95 wants to merge 3 commits into from
Closed

http2: add support for TypedArray to getUnpackedSettings #36141

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2699b66
http2: add support for TypedArray to getUnpackedSettings
aduh95 Nov 16, 2020
b3f7873
fixup! http2: add support for TypedArray to getUnpackedSettings
aduh95 Nov 16, 2020
80f8d3d
fixup! http2: add support for TypedArray to getUnpackedSettings
aduh95 Nov 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! http2: add support for TypedArray to getUnpackedSettings
  • Loading branch information
@aduh95
aduh95 committed Nov 17, 2020
commit 80f8d3d9a4690b36fd374338e38224ae24b3f59b
14 changes: 7 additions & 7 deletions test/parallel/test-http2-getpackedsettings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,15 +200,15 @@ http2.getPackedSettings({ enablePush: false });
0x00, 0x02, 0x00, 0x00, 0x00, 0x01,
0x00, 0x08, 0x00, 0x00, 0x00, 0x00]).buffer);

assert.throws(() => {
http2.getUnpackedSettings(packed);
}, {
code: 'ERR_INVALID_ARG_TYPE',
name: 'TypeError',
message:
assert.throws(() => {
http2.getUnpackedSettings(packed);
}, {
code: 'ERR_INVALID_ARG_TYPE',
name: 'TypeError',
message:
'The "buf" argument must be an instance of Buffer or TypedArray.' +
common.invalidArgTypeHelper(packed)
});
});
}

{
Expand Down