Skip to content

test: update comments in test-fs-read-offset-null #36152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Trott merged 1 commit into from
Nov 21, 2020
Merged

test: update comments in test-fs-read-offset-null #36152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: update comments in test-fs-read-offset-null 
Update comment to refer to the correct ASCII code (120 rather than 66).
All other changes are cosmetic.

PR-URL: #36152
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
  • Loading branch information
@Trott
Trott committed Nov 21, 2020
commit a9f5b2b62c1756107c9bb73ecd12bcb8cf39a128
9 changes: 4 additions & 5 deletions test/parallel/test-fs-read-offset-null.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,16 @@ const fixtures = require('../common/fixtures');
const filepath = fixtures.path('x.txt');

const buf = Buffer.alloc(1);
// Reading only one character, hence buffer of one byte is enough
// Reading only one character, hence buffer of one byte is enough.

// Test for callback api
// Test for callback API.
fs.open(filepath, 'r', common.mustSucceed((fd) => {
fs.read(fd, { offset: null, buffer: buf },
common.mustSucceed((bytesRead, buffer) => {
assert.strictEqual(buffer[0], 120);
// Test is done by making sure the first letter in buffer is
// same as first letter in file.
// 66 is the hex for ascii code of letter B

// 120 is the hex for ascii code of letter x.
assert.strictEqual(buffer[0], 120);
fs.close(fd, common.mustSucceed(() => {}));
}));
}));
Expand Down