Skip to content

process: disallow adding options to process.allowedNodeEnvironmentFlags #36660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aduh95 wants to merge 3 commits into from
Closed

process: disallow adding options to process.allowedNodeEnvironmentFlags #36660

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6262973
process: disallow adding options to process.allowedNodeEnvironmentFlags
aduh95 Dec 28, 2020
eafaa2b
fixup! process: disallow adding options to process.allowedNodeEnviron…
aduh95 Feb 1, 2021
466d928
fixup! fixup! process: disallow adding options to process.allowedNode…
aduh95 Feb 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! fixup! process: disallow adding options to process.allowedNode… 
…EnvironmentFlags
  • Loading branch information
@aduh95
aduh95 committed Feb 17, 2021
commit 466d928b60309014cf079b225aaf52e48958c08d
1 change: 1 addition & 0 deletions test/parallel/test-process-env-allowed-flags.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ const assert = require('assert');
true);

process.allowedNodeEnvironmentFlags.add('foo');
assert.strictEqual(process.allowedNodeEnvironmentFlags.has('foo'), false);
Set.prototype.add.call(process.allowedNodeEnvironmentFlags, 'foo');
assert.strictEqual(process.allowedNodeEnvironmentFlags.has('foo'), false);
Comment thread
aduh95 marked this conversation as resolved.

Expand Down