Skip to content

fs: fix busy loop in recursive rm for windows #36815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RaisinTen wants to merge 3 commits into from
Closed

fs: fix busy loop in recursive rm for windows #36815

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5572faa
fs: fix busy loop in recursive rm for windows
RaisinTen Jan 6, 2021
27e573a
fixup! fs: fix busy loop in recursive rm for windows
RaisinTen May 18, 2021
c3c99a5
fixup! fixup! fs: fix busy loop in recursive rm for windows
RaisinTen May 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fs: fix busy loop in recursive rm for windows 
Fixes: #34580
  • Loading branch information
@RaisinTen
RaisinTen committed May 18, 2021
commit 5572faa5fe30c8b38f10c42765cf1ef45824c7fe
2 changes: 1 addition & 1 deletion lib/internal/fs/rimraf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ function _rmdirSync(path, options, originalErr) {
} catch (err) {
if (err.code === 'ENOENT')
return;
if (err.code === 'ENOTDIR')
if (err.code === 'EACCES' || err.code === 'ENOTDIR')
throw originalErr;

if (notEmptyErrorCodes.has(err.code)) {
Expand Down
54 changes: 54 additions & 0 deletions test/parallel/test-recursive-rm-busy-loop-windows.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
'use strict';
const common = require('../common');

// This test ensures that recursive rm throws EACCES instead of
// going into a busy-loop for this scenario:
// https://github.com/nodejs/node/issues/34580

const assert = require('assert');
const fs = require('fs');
const tmpdir = require('../common/tmpdir');
const { join } = require('path');

if (common.isIBMi)
common.skip('IBMi has a different access permission mechanism');

if (!(common.isWindows || process.getuid() !== 0))
common.skip('Test is not supposed to be run as root.');

tmpdir.refresh();

function makeDirectoryReadOnly(dir) {
if (common.isWindows) {
execSync(`icacls ${dir} /deny "everyone:(OI)(CI)(DE,DC)"`);
} else {
fs.chmodSync(dir, 0o444);
}
}

function makeDirectoryWritable(dir) {
if (common.isWindows) {
execSync(`icacls ${dir} /remove:d "everyone"`);
} else {
fs.chmodSync(dirname, 0o777);
}
}

function rmdirRecursiveSync() {
const root = fs.mkdtempSync(tmpdir.path);

const middle = join(root, 'middle');
fs.mkdirSync(middle);
fs.mkdirSync(join(middle, 'leaf')); // Make `middle` non-empty
makeDirectoryReadOnly(middle);

try {
assert.throws(() => {
fs.rmSync(root, { recursive: true });
}, /EACCES/);
} finally {
makeDirectoryWritable(middle);
}
}

rmdirRecursiveSync();