Skip to content

deps: update V8 to 9.0 #37587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos wants to merge 15 commits into from
Closed

deps: update V8 to 9.0 #37587

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
42b4168
deps: update V8 to 9.0.257.11
targos Mar 12, 2021
5907176
build: reset embedder string to "-node.0"
targos Mar 12, 2021
7669aa9
src: update NODE_MODULE_VERSION to 93
targos Mar 3, 2021
9b2d050
deps: V8: un-cherry-pick bd019bd
refack Mar 27, 2019
2ed3e1b
deps: V8: patch register-arm64.h
refack May 22, 2019
7409ec0
deps: V8: forward declaration of `Rtl*FunctionTable`
refack May 22, 2019
b6b64a8
deps: make v8.h compatible with VS2015
joaocgreis Nov 1, 2019
1430740
deps: fix V8 build issue with inline methods
gengjiawen Oct 14, 2020
f89e610
deps: silence irrelevant V8 warnings
targos Jan 30, 2021
1fe5117
deps: V8: cherry-pick 1648e050cade
targos Mar 12, 2021
0bf6e1e
src: use non-deprecated V8 module APIs
targos Jan 30, 2021
2ab93a5
lib: load v8_prof_processor dependencies as ESM
targos Jan 30, 2021
62710da
tools: update V8 gypfiles for 9.0
targos Jan 29, 2021
a47f565
src: remove V8_FT_ADAPTOR for V8 update
cjihrig Feb 26, 2021
430c7ee
src: use non-deprecated GetCreationContext from V8
targos Feb 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
deps: fix V8 build issue with inline methods 
PR-URL: #35415
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
  • Loading branch information
@gengjiawen @targos
gengjiawen authored and targos committed Mar 12, 2021
commit 14307408c9b82cf9f911a7b48a16c265593a8aa4
2 changes: 1 addition & 1 deletion common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.4',
'v8_embedder_string': '-node.5',

##### V8 defaults for Node.js #####

Expand Down
2 changes: 2 additions & 0 deletions deps/v8/src/objects/fixed-array-inl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,13 +88,15 @@ bool FixedArray::is_the_hole(Isolate* isolate, int index) {
return get(isolate, index).IsTheHole(isolate);
}

#if !defined(_WIN32) || defined(_WIN64)
void FixedArray::set(int index, Smi value) {
DCHECK_NE(map(), GetReadOnlyRoots().fixed_cow_array_map());
DCHECK_LT(static_cast<unsigned>(index), static_cast<unsigned>(length()));
DCHECK(Object(value).IsSmi());
int offset = OffsetOfElementAt(index);
RELAXED_WRITE_FIELD(*this, offset, value);
}
#endif

void FixedArray::set(int index, Object value) {
DCHECK_NE(GetReadOnlyRoots().fixed_cow_array_map(), map());
Expand Down
11 changes: 11 additions & 0 deletions deps/v8/src/objects/fixed-array.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,18 @@ class FixedArray
inline bool is_the_hole(Isolate* isolate, int index);

// Setter that doesn't need write barrier.
#if defined(_WIN32) && !defined(_WIN64)
inline void set(int index, Smi value) {
DCHECK_NE(map(), GetReadOnlyRoots().fixed_cow_array_map());
DCHECK_LT(static_cast<unsigned>(index), static_cast<unsigned>(length()));
DCHECK(Object(value).IsSmi());
int offset = OffsetOfElementAt(index);
RELAXED_WRITE_FIELD(*this, offset, value);
}
#else
inline void set(int index, Smi value);
#endif

// Setter with explicit barrier mode.
inline void set(int index, Object value, WriteBarrierMode mode);

Expand Down
2 changes: 1 addition & 1 deletion deps/v8/src/objects/tagged-field.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ class TaggedField : public AllStatic {
int offset = 0);

static inline void Relaxed_Store(HeapObject host, T value);
static inline void Relaxed_Store(HeapObject host, int offset, T value);
static void Relaxed_Store(HeapObject host, int offset, T value);

static inline T Acquire_Load(HeapObject host, int offset = 0);
static inline T Acquire_Load(IsolateRoot isolate, HeapObject host,
Expand Down