Skip to content

lib: add brand checks to AbortController and AbortSignal #37720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MattiasBuelens wants to merge 6 commits into from
Closed

lib: add brand checks to AbortController and AbortSignal #37720

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
64abc04
lib: add brand checks to AbortController and AbortSignal
MattiasBuelens Mar 11, 2021
048ab00
lib: use optional chaining in brand checks
MattiasBuelens Mar 11, 2021
1de2c66
lib: reformat require for internal/errors
MattiasBuelens Mar 11, 2021
bc87164
test: check if AbortController and AbortSignal validate the receiver
MattiasBuelens Mar 14, 2021
2469b73
test: reword comments
MattiasBuelens Mar 15, 2021
8fa7c54
test: check undefined as well
MattiasBuelens Mar 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lib: reformat require for internal/errors 
Co-authored-by: James M Snell <jasnell@gmail.com>
  • Loading branch information
@MattiasBuelens @jasnell
MattiasBuelens and jasnell committed Mar 15, 2021
commit 1de2c665f1a1eaa2b85bac11cbf6072a1a8a3edc
6 changes: 4 additions & 2 deletions lib/internal/abort_controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,10 @@ const {
} = require('internal/util');
const { inspect } = require('internal/util/inspect');
const {
ERR_INVALID_THIS
} = require('internal/errors').codes;
codes: {
ERR_INVALID_THIS,
}
} = require('internal/errors');

const kAborted = Symbol('kAborted');

Expand Down