Skip to content

tools: simplify eslint comma-dangle configuration (tools) #37883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Trott merged 1 commit into from
Mar 26, 2021
Merged

tools: simplify eslint comma-dangle configuration (tools) #37883

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
tools: simplify eslint comma-dangle configuration (tools) 
Remove the comma-dangle settings in tools/.eslintrc.yaml. They are
duplicated in .eslintrc.js.

PR-URL: #37883
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
@Trott
Trott committed Mar 26, 2021
commit 32296fa1936927794fa22d530ec97297597e49b4
6 changes: 0 additions & 6 deletions tools/.eslintrc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,6 @@ rules:
- properties: 'never'
ignoreDestructuring: true
allow: ['child_process']
comma-dangle:
- error
- arrays: 'always-multiline'
objects: 'only-multiline'
imports: 'only-multiline'
exports: 'only-multiline'
no-unused-vars: [error, { args: 'after-used' }]
prefer-arrow-callback: error
no-var: error