Skip to content

node-api: make reference weak parameter an indirect link to references #38000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
legendecas wants to merge 3 commits into from
Closed

node-api: make reference weak parameter an indirect link to references #38000

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48c95d0
node-api: make reference weak parameter an indirect link to references
legendecas Mar 31, 2021
a85e1f7
squash: update wording, tweak comments
mhdawson Apr 7, 2021
98eecdf
squash: fixup
mhdawson Apr 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
squash: fixup 
Signed-off-by: Michael Dawson <mdawson@devrus.com>
  • Loading branch information
@mhdawson
mhdawson committed Apr 7, 2021
commit 98eecdffd0555a9f9cd88baf18e821ddd466357e
5 changes: 3 additions & 2 deletions src/js_native_api_v8.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,8 @@ class Reference : public RefBase {
return;
}
_persistent.SetWeak(
_secondPassParameter, FinalizeCallback, v8::WeakCallbackType::kParameter);
_secondPassParameter, FinalizeCallback,
v8::WeakCallbackType::kParameter);
*_secondPassParameter = this;
}

Expand Down Expand Up @@ -455,7 +456,6 @@ class Reference : public RefBase {
// of a parameter within the Reference object itself. This is what
// is stored in _secondPassParameter and it is alocated in the
// constructor for the Reference.
SecondPassCallParameterRef* _secondPassParameter;
static void SecondPassCallback(
const v8::WeakCallbackInfo<SecondPassCallParameterRef>& data) {
SecondPassCallParameterRef* parameter = data.GetParameter();
Expand All @@ -469,6 +469,7 @@ class Reference : public RefBase {
}

v8impl::Persistent<v8::Value> _persistent;
SecondPassCallParameterRef* _secondPassParameter;
};

enum UnwrapAction {
Expand Down