Skip to content

test: improve coverage of stream.Readable #38702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pd4d10 wants to merge 4 commits into from
Closed

test: improve coverage of stream.Readable #38702

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6fe42ee
test: improve coverage of stream.Readable
pd4d10 May 16, 2021
2f9871a
Update test/parallel/test-stream-readable-read-size.js
pd4d10 May 16, 2021
1ad71db
move to test-streams-highwatermark.js
pd4d10 May 16, 2021
c41d857
Update test/parallel/test-streams-highwatermark.js
pd4d10 May 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
move to test-streams-highwatermark.js
  • Loading branch information
@pd4d10
pd4d10 committed May 16, 2021
commit 1ad71db1f7960787f83d4f224ff22f340e383c1d
16 changes: 0 additions & 16 deletions test/parallel/test-stream-readable-read-size.js
View file
Open in desktop

This file was deleted.

13 changes: 13 additions & 0 deletions test/parallel/test-streams-highwatermark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,3 +57,16 @@ const { inspect } = require('util');
readable._read = common.mustCall();
readable.read(0);
}

{
// Parse size as decimal integer
['1', '1.0', 1].forEach((size) => {
const readable = new Readable({
Comment thread
pd4d10 marked this conversation as resolved.
Outdated
read: common.mustCall(),
highWaterMark: 0,
});
readable.read(size);

assert.strictEqual(readable._readableState.highWaterMark, Number(size));
});
}