Skip to content

tools: use PrintCaughtException in the snapshot builder #38745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 3 commits into from
Closed

tools: use PrintCaughtException in the snapshot builder #38745

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
90fb545
tools: use PrintCaughtException in the snapshot builder
joyeecheung May 20, 2021
f7d5540
fixup! tools: use PrintCaughtException in the snapshot builder
joyeecheung May 20, 2021
ce5b473
fixup! fixup! tools: use PrintCaughtException in the snapshot builder
joyeecheung May 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! tools: use PrintCaughtException in the snapshot builder 
Co-authored-by: Voltrex <62040526+VoltrexMaster@users.noreply.github.com>
  • Loading branch information
@joyeecheung @VoltrexKeyva
joyeecheung and VoltrexKeyva authored May 20, 2021
commit f7d5540e41f2f3de14b4650ce60f632a82d99164
2 changes: 1 addition & 1 deletion tools/snapshot/snapshot_builder.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ std::string SnapshotBuilder::Generate(
creator.SetDefaultContext(Context::New(isolate));
isolate_data_indexes = main_instance->isolate_data()->Serialize(&creator);

// Run the per-contenxt scripts
// Run the per-context scripts
Local<Context> context;
{
TryCatch bootstrapCatch(isolate);
Expand Down