Skip to content

test: add os setPriority, getPriority test coverage #38771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 3 commits into from
Sep 27, 2023
Merged

test: add os setPriority, getPriority test coverage #38771

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
40d821e
test: add os setPriority, getPriority test coverage
waelsy123 May 22, 2021
02b52c4
fix typo priority
waelsy123 May 23, 2021
80c621a
Update test/parallel/test-os.js
waelsy123 May 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: add os setPriority, getPriority test coverage
  • Loading branch information
@waelsy123 @aduh95
waelsy123 authored and aduh95 committed Sep 20, 2023
commit 40d821e84b1f4cc57925bd8b12d57770ed5a3f3b
6 changes: 6 additions & 0 deletions test/parallel/test-os.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,12 @@ const hostname = os.hostname();
is.string(hostname);
assert.ok(hostname.length > 0);

const DUMMY_PRIORITY = 10
os.setPriority(DUMMY_PRIORITY)
const proiority = os.getPriority()
is.number(proiority)

@jasnell jasnell May 23, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace proiority with priority

@waelsy123 waelsy123 May 23, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks I missed that

assert.ok(proiority === DUMMY_PRIORITY)

// On IBMi, os.uptime() returns 'undefined'
if (!common.isIBMi) {
const uptime = os.uptime();
Expand Down