Skip to content

readline: allow completer to rewrite existing input #39178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 5 commits into from
Closed

readline: allow completer to rewrite existing input #39178

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4d5636e
readline: allow completer to rewrite existing input
addaleax Jun 28, 2021
e69cd1d
fixup! readline: allow completer to rewrite existing input
addaleax Jun 28, 2021
4b4e6c3
fixup! readline: allow completer to rewrite existing input
addaleax Jun 28, 2021
697cf5d
fixup! readline: allow completer to rewrite existing input
addaleax Jun 28, 2021
0a38e28
fixup! readline: allow completer to rewrite existing input
addaleax Jun 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! readline: allow completer to rewrite existing input
  • Loading branch information
@addaleax
addaleax authored Jun 28, 2021
commit e69cd1da8f0c30788589d8b430138e8f705c3986
8 changes: 6 additions & 2 deletions lib/readline.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -709,9 +709,13 @@ Interface.prototype._tabComplete = function(lastKeypressWasTab) {
this._insertString(StringPrototypeSlice(prefix, completeOn.length));
return;
} else if (!completeOn.startsWith(prefix)) {
Comment thread
addaleax marked this conversation as resolved.
Outdated
this.line = StringPrototypeSlice(this.line, 0, this.cursor - completeOn.length) +
this.line = StringPrototypeSlice(this.line,
0,
this.cursor - completeOn.length) +
prefix +
StringPrototypeSlice(this.line, this.cursor, this.line.length);
StringPrototypeSlice(this.line,
this.cursor,
this.line.length);
this.cursor = this.cursor - completeOn.length + prefix.length;
this._refreshLine();
return;
Expand Down