Skip to content

streams: use finished for pump #39203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 4 commits into from
Closed

streams: use finished for pump #39203

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e9a2cc4
streams: use finished for pump
ronag Jun 18, 2021
882f412
fixup
ronag Jun 30, 2021
a4a04d0
fixup
ronag Jun 30, 2021
bc3e7ea
Update lib/internal/streams/pipeline.js
ronag Jul 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup
  • Loading branch information
@ronag
ronag committed Jun 30, 2021
commit a4a04d00c099a48e3399d685d60b97532b87c8d0
6 changes: 4 additions & 2 deletions lib/internal/streams/pipeline.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,21 +134,23 @@ async function pump(iterable, writable, finish) {
});

writable.on('drain', resume);
const cleanup = eos(writable, resume);
const cleanup = eos(writable, { readable: false }, resume);

try {
if (writable.writableNeedDrain) {
await wait();
}

for await (const chunk of iterable) {
if (writable.write(chunk) === false) {
if (!writable.write(chunk)) {
await wait();
}
}

writable.end();

await wait();

finish();
} catch (err) {
finish(error !== err ? aggregateTwoErrors(error, err) : err);
Expand Down