Skip to content

stream: finished should error on errored stream. #39235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 4 commits into from
Closed

stream: finished should error on errored stream. #39235

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c6fb619
stream: finished should error on errored stream.
ronag Jul 2, 2021
1d2286f
fixup
ronag Jul 2, 2021
afc82fa
fixup
ronag Jul 2, 2021
04e1ac6
fixup
ronag Jul 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup
  • Loading branch information
@ronag
ronag committed Jul 2, 2021
commit afc82fa8331b8b29a0c03a090890bb6a39e0bdfb
6 changes: 2 additions & 4 deletions lib/internal/streams/end-of-stream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,7 @@ function eos(stream, options, callback) {
isWritable(stream) === writable
);

let writableFinished = stream.writableFinished ||
(wState && wState.finished);
let writableFinished = stream.writableFinished || wState?.finished;
const onfinish = () => {
writableFinished = true;
// Stream should not be destroyed here. If it is that
Expand All @@ -111,8 +110,7 @@ function eos(stream, options, callback) {
if (!readable || readableEnded) callback.call(stream);
};

let readableEnded = stream.readableEnded ||
(rState && rState.endEmitted);
let readableEnded = stream.readableEnded || rState?.endEmitted;
const onend = () => {
readableEnded = true;
// Stream should not be destroyed here. If it is that
Expand Down