Skip to content

src: add a constructor overload for CallbackScope #39768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RaisinTen wants to merge 2 commits into from
Closed

src: add a constructor overload for CallbackScope #39768

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85073c5
src: add a constructor overload for CallbackScope
RaisinTen Aug 15, 2021
795069a
src: call overload ctor from the original ctor
RaisinTen Aug 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
src: call overload ctor from the original ctor 
Call the new constructor overload from the original constructor to
reduce code duplication.

Signed-off-by: Darshan Sen <darshan.sen@postman.com>
  • Loading branch information
@RaisinTen
RaisinTen committed Aug 17, 2021
commit 795069ad13551e59b61c1312c5cf228a58791745
9 changes: 2 additions & 7 deletions src/api/callback.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,8 @@ using v8::Value;

CallbackScope::CallbackScope(Isolate* isolate,
Local<Object> object,
async_context asyncContext)
: private_(new InternalCallbackScope(Environment::GetCurrent(isolate),
object,
asyncContext)),
try_catch_(isolate) {
try_catch_.SetVerbose(true);
}
async_context async_context)
: CallbackScope(Environment::GetCurrent(isolate), object, async_context) {}

CallbackScope::CallbackScope(Environment* env,
Comment thread
RaisinTen marked this conversation as resolved.
Local<Object> object,
Expand Down