Skip to content

workers, event_target: add brand checks for detached accessors #39773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 3 commits into from
Closed

workers, event_target: add brand checks for detached accessors #39773

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a28436b
workers: add brand checks for detached MessageEvent accessors
jasnell Aug 15, 2021
5a9deb4
event_target: add brand checks for detached accessors
jasnell Aug 15, 2021
ae8fe16
event_target: protect property defs against prototype polution
jasnell Aug 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
event_target: protect property defs against prototype polution 
Signed-off-by: James M Snell <jasnell@gmail.com>
  • Loading branch information
@jasnell
jasnell committed Aug 16, 2021
commit ae8fe16183d495dc6a5756b49cbc18c6fab47d04
5 changes: 5 additions & 0 deletions lib/internal/worker/io.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ ObjectDefineProperties(MessageEvent.prototype, {
},
enumerable: true,
Comment thread
jasnell marked this conversation as resolved.
configurable: true,
set: undefined,
},
origin: {
get() {
Expand All @@ -151,6 +152,7 @@ ObjectDefineProperties(MessageEvent.prototype, {
},
enumerable: true,
Comment thread
jasnell marked this conversation as resolved.
configurable: true,
set: undefined,
},
lastEventId: {
get() {
Expand All @@ -160,6 +162,7 @@ ObjectDefineProperties(MessageEvent.prototype, {
},
enumerable: true,
Comment thread
jasnell marked this conversation as resolved.
configurable: true,
set: undefined,
},
source: {
get() {
Expand All @@ -169,6 +172,7 @@ ObjectDefineProperties(MessageEvent.prototype, {
},
enumerable: true,
Comment thread
jasnell marked this conversation as resolved.
configurable: true,
set: undefined,
},
ports: {
get() {
Expand All @@ -178,6 +182,7 @@ ObjectDefineProperties(MessageEvent.prototype, {
},
enumerable: true,
Comment thread
jasnell marked this conversation as resolved.
configurable: true,
set: undefined,
},
});

Expand Down