Skip to content

util: expose toUSVString #39814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 4 commits into from
Closed

util: expose toUSVString #39814

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e04a10b
util: expose toUSVString
ronag Aug 19, 2021
f2ca87d
Apply suggestions from code review
ronag Aug 20, 2021
918491e
fixup
ronag Aug 20, 2021
62c026f
fixup
ronag Aug 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup
  • Loading branch information
@ronag
ronag committed Aug 21, 2021
commit 62c026f9cbec66528332a6a5200201b90e8cf352
2 changes: 1 addition & 1 deletion test/parallel/test-util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ assert.strictEqual(util.isFunction(function() {}), true);
assert.strictEqual(util.isFunction(), false);
assert.strictEqual(util.isFunction('string'), false);

assert.strictEqual(util.toUSVString('string'), 'string');
assert.strictEqual(util.toUSVString('string\ud801'), 'string\ufffd');

@mathiasbynens mathiasbynens Aug 26, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we’d test lone lead surrogates, lone trail surrogates, and also surrogate pairs (to ensure those are unaffected). Patch: #39891


{
assert.strictEqual(util.types.isNativeError(new Error()), true);
Expand Down