Skip to content

deps: suppress zlib compiler warnings #40343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danbev wants to merge 2 commits into from
Closed

deps: suppress zlib compiler warnings #40343

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a689b6
deps: suppress zlib compiler warnings
danbev Oct 6, 2021
9f53d9a
squash! deps: suppress zlib compiler warnings
danbev Oct 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
squash! deps: suppress zlib compiler warnings 
Move cflags into conditions section and only enable for non-windows
architectures.
  • Loading branch information
@danbev
danbev committed Oct 11, 2021
commit 9f53d9ab898babfc5383744ac673ab05e53f862a
2 changes: 1 addition & 1 deletion deps/zlib/zlib.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,10 @@
'.',
],
},
'cflags': [ '-Wno-implicit-fallthrough' ],
'conditions': [
['OS!="win"', {
'cflags!': [ '-ansi' ],
'cflags': [ '-Wno-implicit-fallthrough' ],
'defines': [ 'HAVE_HIDDEN' ],
}],
['OS=="mac" or OS=="ios" or OS=="freebsd" or OS=="android"', {
Expand Down