Skip to content

doc, src: improve default read length #40347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wbt wants to merge 2 commits into from
Closed

doc, src: improve default read length #40347

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a9750a
Provide a more sensible default length
wbt Oct 6, 2021
8642a54
Update docs on read function to correspond
wbt Oct 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Provide a more sensible default length 
Currently, specifying an `offset` without a `length` throws an ERR_OUT_OF_RANGE error.  This provides a more sensible default.
This change should only affect cases where no length is specified and a nonzero offset is, which are currently throwing errors.
  • Loading branch information
@wbt
wbt authored Oct 6, 2021
commit 2a9750a762edc589c0f735d63769a9e6d6c8ec65
2 changes: 1 addition & 1 deletion lib/fs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,7 +621,7 @@ function read(fd, buffer, offset, length, position, callback) {
({
buffer = Buffer.alloc(16384),
offset = 0,
length = buffer.byteLength,
length = buffer.byteLength - offset,
position
} = options);
}
Expand Down