Skip to content

webstreams: clean after the cancel algorithm of readablestream throw error #41366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 3 commits into from
Feb 26, 2022
Merged

webstreams: clean after the cancel algorithm of readablestream throw error #41366

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
331bda7
lib: clean after the cancel algorithm throw error
MoonBall Dec 31, 2021
c308d8a
add test
MoonBall Jan 4, 2022
77b84af
fix lint error
MoonBall Jan 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add test
  • Loading branch information
@MoonBall
MoonBall committed Jan 4, 2022
commit c308d8aa4012580a25cd123d2104b8b990b41cb2
30 changes: 30 additions & 0 deletions test/parallel/test-whatwg-readablestream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,36 @@ const {
assert(r.locked);
}

{
// Throw error and return rejected promise in `cancel()` method
// would execute same cleanup code
const r1 = new ReadableStream({
cancel: () => {
return Promise.reject('Cancel Error');
},
});
r1.cancel().finally(common.mustCall(() => {
const controllerState = r1[kState].controller[kState];

assert.deepEqual(controllerState.pullAlgorithm, undefined)
assert.deepEqual(controllerState.cancelAlgorithm, undefined)
assert.deepEqual(controllerState.sizeAlgorithm, undefined)
})).catch(() => {});

const r2 = new ReadableStream({
cancel() {
throw Error('Cancel Error');
}
});
r2.cancel().finally(common.mustCall(() => {
const controllerState = r2[kState].controller[kState];

assert.deepEqual(controllerState.pullAlgorithm, undefined)
assert.deepEqual(controllerState.cancelAlgorithm, undefined)
assert.deepEqual(controllerState.sizeAlgorithm, undefined)
})).catch(() => {});
}

{
const source = {
start: common.mustCall((controller) => {
Expand Down