Skip to content

http,https: add default argument for Agent.prototype.getName #41906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 4 commits into from
Feb 27, 2022
Merged

http,https: add default argument for Agent.prototype.getName #41906

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5747d9f
http: add default argument for Agent.prototype.getName
xtx1130 Feb 9, 2022
f513e4a
doc: change `agent.getName`'s argumnet to be optional
xtx1130 Feb 10, 2022
32e574b
doc: Update doc/api/http.md
xtx1130 Feb 11, 2022
69a6bfb
doc: Update doc/api/http.md
xtx1130 Feb 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
doc: Update doc/api/http.md 
Co-authored-by: Mestery <mestery@protonmail.com>
  • Loading branch information
@xtx1130 @Mesteery
xtx1130 and Mesteery authored Feb 11, 2022
commit 69a6bfbc143675582e766bd681923a092ad7f3eb
2 changes: 1 addition & 1 deletion doc/api/http.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ added: v0.11.4
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/41906
description: The `option` parameter is now optional.
description: The `options` parameter is now optional.
-->

* `options` {Object} A set of options providing information for name generation
Expand Down