Skip to content

doc: clarify tls.Server 'connection' event documentation #41917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 2 commits into from
Feb 12, 2022
Merged

doc: clarify tls.Server 'connection' event documentation #41917

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60b2cd6
tls: updating documentation in consideration of issue #41880
prettydiff Feb 9, 2022
3c7bdb5
Update doc/api/tls.md
prettydiff Feb 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
tls: updating documentation in consideration of issue #41880
  • Loading branch information
@prettydiff
prettydiff committed Feb 9, 2022
commit 60b2cd64702b59b49e7562df274e84ad9ae51758
5 changes: 3 additions & 2 deletions doc/api/tls.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,8 +432,9 @@ added: v0.3.2
* `socket` {stream.Duplex}

This event is emitted when a new TCP stream is established, before the TLS
handshake begins. `socket` is typically an object of type [`net.Socket`][].
Usually users will not want to access this event.
handshake begins. `socket` is typically an object of type [`net.Socket`][] but
will not receive events unlike the socket created from the [`net.Server`][]
`connection` event. Usually users will not want to access this event.
Comment thread
prettydiff marked this conversation as resolved.
Outdated

This event can also be explicitly emitted by users to inject connections
into the TLS server. In that case, any [`Duplex`][] stream can be passed.
Expand Down