Skip to content

stream: add more forEach tests #41937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benjamingr wants to merge 3 commits into from
Closed

stream: add more forEach tests #41937

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4965229
stream: add more forEach tests
benjamingr Feb 11, 2022
188068b
Update test/parallel/test-stream-forEach.js
benjamingr Feb 12, 2022
fa333dd
fixup! no timers
benjamingr Feb 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! no timers
  • Loading branch information
@benjamingr
benjamingr committed Feb 14, 2022
commit fa333dd467a41990064829af077df80f785d26de
4 changes: 2 additions & 2 deletions test/parallel/test-stream-forEach.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const {
Readable,
} = require('stream');
const assert = require('assert');
const { setTimeout } = require('timers/promises');
const { once } = require('events');

{
// forEach works on synchronous streams with a synchronous predicate
Expand Down Expand Up @@ -95,7 +95,7 @@ const { setTimeout } = require('timers/promises');
const forEachPromise =
Readable.from([1, 2, 3, 4]).forEach(async (_, { signal }) => {
calls++;
await setTimeout(100, { signal });
await once(signal, 'abort');
}, { signal: ac.signal, concurrency: 2 });
// pump
assert.rejects(async () => {
Expand Down