Skip to content

lib: stop installing fetch if no_browser_globals is true #41969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Feb 16, 2022
Merged

lib: stop installing fetch if no_browser_globals is true #41969

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
lib: stop installing fetch if no_browser_globals is true 
Fixes: #41816
Signed-off-by: Darshan Sen <raisinten@gmail.com>
  • Loading branch information
@RaisinTen
RaisinTen committed Feb 14, 2022
commit 6f7bae19c7ae0920b22107376ec7617c40ad1fd4
3 changes: 2 additions & 1 deletion lib/internal/bootstrap/pre_execution.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,8 @@ function setupWarningHandler() {

// https://fetch.spec.whatwg.org/
function setupFetch() {
if (!getOptionValue('--experimental-fetch')) {
if (process.config.variables.node_no_browser_globals ||
!getOptionValue('--experimental-fetch')) {
return;
}

Expand Down