Skip to content

esm: fix base URL for network imports #42131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bmeck wants to merge 6 commits into from
Closed

esm: fix base URL for network imports #42131

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
be6806b
esm: fix base URL for network imports
bmeck Feb 25, 2022
03f54a8
fixup: lint
bmeck Feb 25, 2022
b9c145a
fixup: Update lib/internal/modules/esm/loader.js
bmeck Feb 25, 2022
c336ad0
fixup: Apply suggestions from code review
bmeck Feb 25, 2022
e0da1a3
fixup: assert baseURL is a string for network modules
bmeck Feb 28, 2022
d6e8326
fixup: apply code review changes
bmeck Mar 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: Apply suggestions from code review 
Co-authored-by: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
  • Loading branch information
@bmeck @VoltrexKeyva
bmeck and VoltrexKeyva committed Mar 2, 2022
commit c336ad07fd21eb5ec56cdf9b049e853cd8d99c6b
2 changes: 1 addition & 1 deletion lib/internal/modules/esm/loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ class ESMLoader {
}

/**
* Returns the url to use for resolution for a given cache key url
* Returns the url to use for the resolution of a given cache key url
* These are not guaranteed to be the same.
*
* In WHATWG HTTP spec for ESM the cache key is the non-I/O bound
Comment thread
bmeck marked this conversation as resolved.
Expand Down
2 changes: 1 addition & 1 deletion test/es-module/test-http-imports.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ for (const { protocol, createServer } of [
assert.strict.notEqual(redirectedNS.default, ns.default);
assert.strict.equal(redirectedNS.url, url.href);

// Redirects have same import.meta.url but different cache
// Redirects have the same import.meta.url but different cache
// entry on Web
const relativeAfterRedirect = new url("https://github.com/nodejs/node/pull/42131/commits/url.href%20+%20'foo/index.js'");
const redirected = new url("https://github.com/nodejs/node/pull/42131/commits/url.href%20+%20'bar/index.js'");
Comment thread
bmeck marked this conversation as resolved.
Expand Down