Skip to content

policy: cleanup to allow snapshotting #42191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bmeck wants to merge 9 commits into from
Closed

policy: cleanup to allow snapshotting #42191

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
521f044
policy: cleanup to allow snapshotting
bmeck Mar 2, 2022
28c153a
fixup: lint
bmeck Mar 2, 2022
19e3aa4
fixup: cleanup and rebase
bmeck Mar 18, 2022
2e47f73
fixup: test
bmeck Mar 18, 2022
eb0893a
fixup: clarifying doc on policy.setup(null)
bmeck Mar 18, 2022
ba32054
fixup: lint
bmeck Mar 18, 2022
c85b8e5
fixup: lint
bmeck Mar 18, 2022
1b2d5bb
fixup: review nit
bmeck Mar 22, 2022
d695c78
fixup: CI fix for non-crypto build
bmeck Mar 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: cleanup and rebase
  • Loading branch information
@bmeck
bmeck committed Mar 18, 2022
commit 19e3aa4433a69499bdf953a79f91d4436c2a4fc0
16 changes: 7 additions & 9 deletions lib/internal/policy/manifest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,22 +345,20 @@ function findScopeHREF(href, scopeStore, allowSame) {
* @typedef {boolean | string | SRI[] | typeof kCascade} Integrity
*/

let URL;
let shouldAbortOnUncaughtException;
Comment thread
bmeck marked this conversation as resolved.
Outdated
let createHash, timingSafeEqual, HashUpdate, HashDigest;
const crypto = require('crypto');
const timingSafeEqual = crypto.timingSafeEqual;
const createHash = crypto.createHash;
const HashUpdate = uncurryThis(crypto.Hash.prototype.update);
const HashDigest = uncurryThis(crypto.Hash.prototype.digest);
const { getOptionValue } = require('internal/options');
const { URL } = require('internal/url');
// To get this in the snapshot we can't have things that use getOptionsValue or
// expose C++ functions so we do these lazily
Comment thread
bmeck marked this conversation as resolved.
function lazyBits() {
const { getOptionValue } = require('internal/options');
shouldAbortOnUncaughtException = getOptionValue(
'--abort-on-uncaught-exception'
);
URL = require('internal/url').URL;
const crypto = require('crypto');
timingSafeEqual = crypto.timingSafeEqual;
createHash = crypto.createHash;
HashUpdate = uncurryThis(crypto.Hash.prototype.update);
HashDigest = uncurryThis(crypto.Hash.prototype.digest);
}

class Manifest {
Expand Down