Skip to content

[v14.x] deps: upgrade npm to 6.14.17 #42900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ruyadorno wants to merge 7 commits into from
Closed

[v14.x] deps: upgrade npm to 6.14.17 #42900

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
03e9572
doc: use openpgp.org for keyserver examples
nschonni Feb 18, 2022
40b0f8f
build: use ccache in make-v8.sh on ppc64le and s390x
richardlau Mar 7, 2022
608333e
worker: do not send message if port is closing
Trott Mar 16, 2022
97083bc
doc: specify flag needed for JSON and Wasm modules
Trott Apr 14, 2022
b89d4ef
deps: V8: cherry-pick 367b0c1e7a32
legendecas Apr 7, 2022
3d6255f
deps: V8: cherry-pick cc9a8a37445e
devsnek Feb 2, 2022
874e907
deps: upgrade npm to 6.14.17
ruyadorno Apr 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
worker: do not send message if port is closing 
Fixes: #42296

PR-URL: #42357
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
  • Loading branch information
@Trott @juanarbol
Trott authored and juanarbol committed Apr 28, 2022
commit 608333e10557ac96d58c996f266c3755566feda9
2 changes: 1 addition & 1 deletion src/node_messaging.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -964,7 +964,7 @@ void MessagePort::PostMessage(const FunctionCallbackInfo<Value>& args) {
// Even if the backing MessagePort object has already been deleted, we still
// want to serialize the message to ensure spec-compliant behavior w.r.t.
// transfers.
if (port == nullptr) {
if (port == nullptr || port->IsHandleClosing()) {
Message msg;
USE(msg.Serialize(env, context, args[0], transfer_list, obj));
return;
Expand Down
8 changes: 8 additions & 0 deletions test/parallel/test-worker-message-port-close.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,3 +39,11 @@ function dummy() {}
message: 'Cannot send data on closed MessagePort'
});
}

// Refs: https://github.com/nodejs/node/issues/42296
{
const ch = new MessageChannel();
ch.port1.onmessage = common.mustNotCall();
ch.port2.close();
ch.port2.postMessage('fhqwhgads');
}