Skip to content

esm: fix http(s) import via custom loader #43130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 8 commits into from
May 25, 2022
Merged

esm: fix http(s) import via custom loader #43130

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e1ebe9a
esm: fix http(s) import via custom loader
JakobJingleheimer May 17, 2022
b1d06bd
fixup: add test case
JakobJingleheimer May 20, 2022
714f94e
fixup: expand code docs for `ESMLoader::getBaseURL` and update return…
JakobJingleheimer May 20, 2022
8aaa873
fixup: de-lint
JakobJingleheimer May 20, 2022
59a5de3
fixup: emphasis gotcha
JakobJingleheimer May 20, 2022
98d262d
use inFetchCache guard
guybedford May 20, 2022
12696a5
lint fixes
guybedford May 20, 2022
eec8253
Apply suggestions from code review
aduh95 May 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestions from code review
  • Loading branch information
@aduh95
aduh95 authored May 24, 2022
commit eec825360cb38d43dc23cfd03c40ae7fe39296d5
4 changes: 2 additions & 2 deletions test/es-module/test-esm-loader-http-imports.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,10 @@ const {
child.stdout.on('data', (data) => stdout += data);

child.on('close', mustCall((code, signal) => {
strictEqual(code, 0);
strictEqual(signal, null);
strictEqual(stderr, '');
strictEqual(stdout, '[Module: null prototype] { sum: [Function: sum] }\n');
strictEqual(code, 0);
strictEqual(signal, null);

server.close();
}));
Expand Down
6 changes: 3 additions & 3 deletions test/fixtures/es-module-loaders/http-loader.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@ export function resolve(specifier, context, nextResolve) {
if (specifier.startsWith('http://')) {
return {
shortCircuit: true,
url: specifier
url: specifier,
};
} else if (parentURL && parentURL.startsWith('http://')) {
} else if (parentURL?.startsWith('http://')) {
return {
shortCircuit: true,
url: new url("https://github.com/nodejs/node/pull/43130/commits/specifier,%20parentURL").href
url: new url("https://github.com/nodejs/node/pull/43130/commits/specifier,%20parentURL").href,
};
}

Expand Down