Skip to content

esm: convert resolve hook to synchronous #43363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 15 commits into from
Jun 18, 2022
Merged

esm: convert resolve hook to synchronous #43363

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
37abe52
esm: convert `resolve` hook to synchronous
JakobJingleheimer Jun 6, 2022
edb6ba5
fixup: fix import.meta.resolve
JakobJingleheimer Jun 12, 2022
ae8ef63
fixup: correct `assert.throws()`
JakobJingleheimer Jun 12, 2022
8bf7965
fixup: support detecting when a resolve hook returns a promise
JakobJingleheimer Jun 12, 2022
ab935b6
fixup: change async/thenable detection
JakobJingleheimer Jun 12, 2022
28d813f
fixup: update ESM doc for resolve hook
JakobJingleheimer Jun 12, 2022
b332b97
fixup: revert back to arg destructuring
JakobJingleheimer Jun 12, 2022
640c91c
fixup: add perf caveat to `resolve` docs
JakobJingleheimer Jun 15, 2022
6c8de26
fixup: wordsmith resolve hook perf caveat
JakobJingleheimer Jun 15, 2022
6416e1d
fixup: re-connect async hook promise chain
JakobJingleheimer Jun 15, 2022
f02b869
fixup: de-lint
JakobJingleheimer Jun 15, 2022
57d6686
fixup: correct missed doc refs to `asynchronous`
JakobJingleheimer Jun 15, 2022
539f7a5
fixup: add browser-alignment note to `import.meta.resolve()`
JakobJingleheimer Jun 17, 2022
83c2072
fixup: account for `null` hook return & first assert `url` is nullish
JakobJingleheimer Jun 17, 2022
e0511b6
fixup: tidy docs changes
JakobJingleheimer Jun 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup: tidy docs changes 
Co-authored-by: Geoffrey Booth <456802+GeoffreyBooth@users.noreply.github.com>
  • Loading branch information
@JakobJingleheimer @GeoffreyBooth
JakobJingleheimer and GeoffreyBooth authored Jun 17, 2022
commit e0511b60b3a740b5262f535ecf2c7147fbeb0cd2
6 changes: 3 additions & 3 deletions doc/api/esm.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,11 +344,11 @@ command flag enabled.
* Returns: {string}
Comment thread
JakobJingleheimer marked this conversation as resolved.

Provides a module-relative resolution function scoped to each module, returning
the URL string. In alignment with browser behaviour, this now returns
the URL string. In alignment with browser behavior, this now returns
synchronously.

> **Caveat** This can result in synchronous file-system operations, which
> can impact performance.
> can impact performance similarly to `require.resolve`.

<!-- eslint-skip -->

Expand Down Expand Up @@ -773,7 +773,7 @@ changes:
terminate the chain of `resolve` hooks. **Default:** `false`
* `url` {string} The absolute URL to which this input resolves

> **Caveat** A resolve hook can contain synchronous file-system operations
> **Caveat** A resolve hook can contain synchronous file-system operations
> (as `defaultResolveHook()` does), which can impact performance.

The `resolve` hook chain is responsible for resolving file URL for a given
Expand Down