Skip to content

lib: refactor to avoid unsafe regex primordials #43475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 3 commits into from
Jun 27, 2022
Merged

lib: refactor to avoid unsafe regex primordials #43475

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
929593c
lib: refactor to avoid unsafe regex primordials
aduh95 Jun 17, 2022
ef6fc53
fixup! lib: refactor to avoid unsafe regex primordials
aduh95 Jun 18, 2022
b3fad29
revert changes in `internal/net` to fix perf regression
aduh95 Jun 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
revert changes in internal/net to fix perf regression
  • Loading branch information
@aduh95
aduh95 committed Jun 20, 2022
commit b3fad292270a38df785397f016b230557ca8ec6b
6 changes: 3 additions & 3 deletions lib/internal/net.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

const {
RegExp,
RegExpPrototypeExec,
RegExpPrototypeTest,
Symbol,
} = primordials;

Expand All @@ -29,11 +29,11 @@ const IPv6Reg = new RegExp('^(' +
')(%[0-9a-zA-Z-.:]{1,})?$');

function isIPv4(s) {
return RegExpPrototypeExec(IPv4Reg, s) !== null;
return RegExpPrototypeTest(IPv4Reg, s);
}

function isIPv6(s) {
return RegExpPrototypeExec(IPv6Reg, s) !== null;
return RegExpPrototypeTest(IPv6Reg, s);
}

function isIP(s) {
Expand Down