Skip to content

test_runner: validate concurrency option #43976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 3 commits into from
Jul 26, 2022
Merged

test_runner: validate concurrency option #43976

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
79c43ae
test_runner: validate `concurrency` option
aduh95 Jul 24, 2022
944b575
fixup! test_runner: validate `concurrency` option
aduh95 Jul 24, 2022
6ff9dd6
fixup! test_runner: validate `concurrency` option
aduh95 Jul 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! test_runner: validate concurrency option
  • Loading branch information
@aduh95
aduh95 committed Jul 24, 2022
commit 944b575738b297876ba29a0dff385f45ae36727c
6 changes: 3 additions & 3 deletions lib/internal/test_runner/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ const { once } = require('events');
const { AbortController } = require('internal/abort_controller');
const {
codes: {
ERR_INVALID_ARG_TYPE,
ERR_TEST_FAILURE,
},
kIsNodeError,
Expand All @@ -36,7 +37,6 @@ const {
validateAbortSignal,
validateNumber,
validateUint32,
validateOneOf,
} = require('internal/validators');
const { setTimeout } = require('timers/promises');
const { TIMEOUT_MAX } = require('internal/timers');
Expand Down Expand Up @@ -152,7 +152,7 @@ class Test extends AsyncResource {

switch (typeof concurrency) {
case 'number':
validateUint32(concurrency, 'concurrency', 1);
validateUint32(concurrency, 'options.concurrency', 1);
this.concurrency = concurrency;
break;

Expand All @@ -166,7 +166,7 @@ class Test extends AsyncResource {

default:
if (concurrency != null)
validateOneOf(concurrency, 'concurrency', ['boolean', 'number']);
throw new ERR_INVALID_ARG_TYPE('options.concurrency', ['boolean', 'number'], concurrency);
}

if (timeout != null && timeout !== Infinity) {
Expand Down