Skip to content

test: fix test/internet/test-inspector-help-page #44025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Jul 31, 2022
Merged

test: fix test/internet/test-inspector-help-page #44025

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: fix internet/test-inspector-help-page 
This gets the test to use its own `https.agent` instead of the default
one.

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
  • Loading branch information
@daeyeon
daeyeon committed Jul 28, 2022
commit b8c5da820676074453b61e8a71a865a40ec8feb8
2 changes: 1 addition & 1 deletion test/internet/test-inspector-help-page.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const stderr = child.stderr.toString();
const helpUrl = stderr.match(/For help, see: (.+)/)[1];

function check(url, cb) {
https.get(url, common.mustCall((res) => {
https.get(url, { agent: new https.Agent() }, common.mustCall((res) => {
assert(res.statusCode >= 200 && res.statusCode < 400);

if (res.statusCode >= 300)
Expand Down