Skip to content

bootstrap: check more metadata when loading the snapshot #44132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 4 commits into from
Aug 9, 2022
Merged

bootstrap: check more metadata when loading the snapshot #44132

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e65d693
bootstrap: check more metadata when loading the snapshot
joyeecheung Aug 4, 2022
3b83287
fixup! bootstrap: check more metadata when loading the snapshot
joyeecheung Aug 4, 2022
6f4a5e7
fixup! fixup! bootstrap: check more metadata when loading the snapshot
joyeecheung Aug 5, 2022
76ec477
fixup! fixup! fixup! bootstrap: check more metadata when loading the …
joyeecheung Aug 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! fixup! bootstrap: check more metadata when loading the snapshot
  • Loading branch information
@joyeecheung
joyeecheung committed Aug 8, 2022
commit 6f4a5e70c1b62b2c813f30a78b52eccf248b072e
2 changes: 1 addition & 1 deletion src/node.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1266,7 +1266,7 @@ int LoadSnapshotDataAndRun(const SnapshotData** snapshot_data_ptr,
// snapshot, but we will skip it if --no-node-snapshot is specified.
const node::SnapshotData* read_data =
SnapshotBuilder::GetEmbeddedSnapshotData();
if (read_data->Check()) {
if (read_data != nullptr && read_data->Check()) {

@joyeecheung joyeecheung Aug 5, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed a bug for cross-compiled binaries.

// If we fail to read the embedded snapshot, treat it as if Node.js
// was built without one.
*snapshot_data_ptr = read_data;
Expand Down