Skip to content

doc,test: improvements and cleanup for assert.snapshot() #44429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cjihrig merged 3 commits into from
Sep 1, 2022
Merged

doc,test: improvements and cleanup for assert.snapshot() #44429

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39998c9
doc: improve assert.snapshot() docs
cjihrig Aug 28, 2022
1fe4e55
test: style updates for assert.snapshot()
cjihrig Aug 28, 2022
cf7539a
doc: add --update-assert-snapshot to node.1
cjihrig Aug 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: style updates for assert.snapshot() 
This commit updates the assert.snapshot() fixtures to better
match the code style of the rest of the codebase.

PR-URL: #44429
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
  • Loading branch information
@cjihrig
cjihrig committed Sep 1, 2022
commit 1fe4e5584045dbe82dda888bf06f23230f6c369e
2 changes: 1 addition & 1 deletion test/fixtures/assert-snapshot/basic.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
import assert from 'node:assert';

await assert.snapshot("test", "name");
await assert.snapshot('test', 'name');
4 changes: 2 additions & 2 deletions test/fixtures/assert-snapshot/multiple.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import assert from 'node:assert';

await assert.snapshot("test", "name");
await assert.snapshot("test", "another name");
await assert.snapshot('test', 'name');
await assert.snapshot('test', 'another name');
4 changes: 2 additions & 2 deletions test/fixtures/assert-snapshot/non-existing-name.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import assert from 'node:assert';

await assert.snapshot("test", "another name");
await assert.snapshot("test", "non existing");
await assert.snapshot('test', 'another name');
await assert.snapshot('test', 'non existing');
2 changes: 1 addition & 1 deletion test/fixtures/assert-snapshot/single.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
import assert from 'node:assert';

await assert.snapshot("test", "snapshot");
await assert.snapshot('test', 'snapshot');
2 changes: 1 addition & 1 deletion test/fixtures/assert-snapshot/value-changed.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
import assert from 'node:assert';

await assert.snapshot("changed", "snapshot");
await assert.snapshot('changed', 'snapshot');