Skip to content

bootstrap: update comments in bootstrap/node.js #44726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 2 commits into from
Closed

bootstrap: update comments in bootstrap/node.js #44726

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62c640b
bootstrap: update comments in bootstrap/node.js
joyeecheung Sep 19, 2022
ccd5762
fixup! bootstrap: update comments in bootstrap/node.js
joyeecheung Sep 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! bootstrap: update comments in bootstrap/node.js 
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
Co-authored-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
  • Loading branch information
@joyeecheung @lpinca @daeyeon
3 people authored Sep 20, 2022
commit ccd57622dba6a1c7c579236006182b3e3b86d3b6
6 changes: 3 additions & 3 deletions lib/internal/bootstrap/node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
// Hello, and welcome to hacking node.js!
//
// This file is invoked by `Realm::BootstrapNode()` in `src/node_realm.cc`,
// and is responsible for setting up node.js core before main scripts
// and is responsible for setting up Node.js core before main scripts
// under `lib/internal/main/` are executed.
//
// By default, Node.js binaries come with an embedded V8 startup snapshot
// that is generated at build-time with a `node_mksnapshot` executable.
// The snapshot generation code can be found in `SnapshotBuilder::Generate()`
// from `src/node_snapshotable.cc`
// from `src/node_snapshotable.cc`.
// This snapshot captures the V8 heap initialized by scripts under
// `lib/internal/bootstrap/`, including this file. When initializing the main
// thread, Node.js deserializes the heap from the snapshot, instead of actually
Expand Down Expand Up @@ -49,7 +49,7 @@
'use strict';

// This file is compiled as if it's wrapped in a function with arguments
// passed by BuiltinLoader::CompileAndCall().
// passed by `BuiltinLoader::CompileAndCall()`.
/* global process, require, internalBinding, primordials */

setupPrepareStackTrace();
Expand Down