Skip to content

[v16.x backport] tools: refactor avoid-prototype-pollution lint rule #44926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aduh95 wants to merge 3 commits into from
Closed

[v16.x backport] tools: refactor avoid-prototype-pollution lint rule #44926

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
816d449
readline: refactor to avoid unsafe regex primordials
aduh95 Oct 8, 2022
a15e589
tools: refactor `avoid-prototype-pollution` lint rule
aduh95 Jun 17, 2022
f8364c5
tools: fix typo in `avoid-prototype-pollution` lint rule
aduh95 Aug 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
tools: fix typo in avoid-prototype-pollution lint rule 
PR-URL: #44446
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
  • Loading branch information
@aduh95
aduh95 committed Oct 11, 2022
commit f8364c5393adcac83e885abe75f3c3aa6d0cbdc7
4 changes: 2 additions & 2 deletions tools/eslint-rules/avoid-prototype-pollution.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,15 +168,15 @@ module.exports = {
[CallExpression('PromisePrototypeCatch')](node) {
context.report({
node,
message: '%Promise.prototype.catch% look up the `then` property of ' +
message: '%Promise.prototype.catch% looks up the `then` property of ' +
'the `this` argument, use PromisePrototypeThen instead',
});
},

[CallExpression('PromisePrototypeFinally')](node) {
context.report({
node,
message: '%Promise.prototype.finally% look up the `then` property of ' +
message: '%Promise.prototype.finally% looks up the `then` property of ' +
'the `this` argument, use SafePromisePrototypeFinally or ' +
'try/finally instead',
});
Expand Down