Skip to content

node-api: handle no support for external buffers #45181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mhdawson wants to merge 11 commits into from
Closed

node-api: handle no support for external buffers #45181

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e29b2c0
node-api: handle no support for external buffers
mhdawson Oct 25, 2022
9d67a66
Update doc/api/n-api.md
mhdawson Oct 26, 2022
ac56ab0
Update n-api.md
mhdawson Oct 26, 2022
5ba9934
Update js_native_api.h
mhdawson Oct 27, 2022
ebefb2b
squash: address review comments
mhdawson Oct 28, 2022
a8038ac
Update doc/api/n-api.md
mhdawson Oct 31, 2022
e66382b
squash: switch define used to check for cage
mhdawson Nov 1, 2022
15a43d6
address review comments
mhdawson Nov 1, 2022
d3f0252
address review comments
mhdawson Nov 1, 2022
874cac1
squash: address review comments
mhdawson Nov 2, 2022
981f9ae
squash: address comments
mhdawson Nov 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update doc/api/n-api.md 
Co-authored-by: Chengzhong Wu <legendecas@gmail.com>
  • Loading branch information
@mhdawson @legendecas
mhdawson and legendecas authored Oct 26, 2022
commit 9d67a665a530422993fce6002283821f2d0a1fc1
2 changes: 1 addition & 1 deletion doc/api/n-api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2362,7 +2362,7 @@ This API allocates a JavaScript value with external data attached to it. This
is used to pass external data through JavaScript code, so it can be retrieved
later by native code using [`napi_get_value_external`][].

**Some runtimes other than Node.ja hasve dropped support for external buffers**.
**Some runtimes other than Node.ja have dropped support for external buffers**.
Comment thread
mhdawson marked this conversation as resolved.
Outdated
On runtimes other than Node.js this method may return
`napi_no_external_buffers_allowed` to indicate that external
buffers are not supported. One such runtime is electron as

@vmoroz vmoroz Nov 1, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we spell Electron with an upper-case letter first?

@mhdawson mhdawson Nov 1, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update

Expand Down