Skip to content

test: add a test to ensure the correctness of timezone upgrades #45299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 7 commits into from
Nov 10, 2022
Merged

test: add a test to ensure the correctness of timezone upgrades #45299

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3f2e5e3
test: add a test to ensure the correctness of timezone upgrades
RaisinTen Nov 3, 2022
f004140
fixup! test: address review comments and skip if no intl
RaisinTen Nov 3, 2022
8780765
fixup! test: intl -> Intl in skip message
RaisinTen Nov 4, 2022
693f9bc
fixup! test: add extra guards
RaisinTen Nov 4, 2022
69ec584
fixup! test: add link to canned icu directory path
RaisinTen Nov 4, 2022
c3ee434
fixup! test: explain difference between small-icu and deps/icu-small
RaisinTen Nov 6, 2022
dfa9a34
fixup! test: fix typo configured -> configure
RaisinTen Nov 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! test: intl -> Intl in skip message 
Signed-off-by: Darshan Sen <raisinten@gmail.com>
  • Loading branch information
@RaisinTen
RaisinTen committed Nov 4, 2022
commit 8780765fb5bd38e0c045c0055c23122129264e76
2 changes: 1 addition & 1 deletion test/parallel/test-tz-version.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
const common = require('../common');

if (!common.hasIntl) {
common.skip('missing intl');
common.skip('missing Intl');
}

const fixtures = require('../common/fixtures');
Expand Down