Skip to content

lib: improve AbortController creation duration #45525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anonrig wants to merge 2 commits into from
Closed

lib: improve AbortController creation duration #45525

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc55d08
lib: improve AbortController creation duration
anonrig Nov 19, 2022
34489fe
lib: improve transferable abort controller exec
anonrig Nov 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
lib: improve AbortController creation duration
  • Loading branch information
@anonrig
anonrig committed Nov 19, 2022
commit cc55d082c37e857a6f5e4a672b946a30d8456926
5 changes: 3 additions & 2 deletions lib/internal/abort_controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,20 +309,21 @@ function abortSignal(signal, reason) {
}

class AbortController {
#signal = createAbortSignal();
#signal;

/**
* @type {AbortSignal}
*/
get signal() {
this.#signal ??= createAbortSignal();
return this.#signal;
}

/**
* @param {any} reason
*/
abort(reason = new DOMException('This operation was aborted', 'AbortError')) {
abortSignal(this.#signal, reason);
abortSignal(this.#signal ??= createAbortSignal(), reason);
}

[customInspectSymbol](depth, options) {
Expand Down