Skip to content

vm: properly support symbols on globals #46458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 3 commits into from
Feb 4, 2023
Merged

vm: properly support symbols on globals #46458

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0599236
vm: properly support symbols on globals
dubzzz Feb 1, 2023
020bc92
Adding missing is_contextual_store||check
dubzzz Feb 1, 2023
b24cd68
Update test/parallel/test-vm-global-symbol.js
dubzzz Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/node_contextify.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,9 @@ void ContextifyContext::PropertySetterCallback(
return;

USE(ctx->sandbox()->Set(context, property, value));
args.GetReturnValue().Set(value);
if (is_function) {
args.GetReturnValue().Set(value);
}
}

// static
Expand Down
15 changes: 15 additions & 0 deletions test/parallel/test-vm-global-symbol.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
'use strict';
require('../common');
const assert = require('assert');
const vm = require('vm');

const global = vm.runInContext('this', vm.createContext());
const totoSymbol = Symbol.for('toto');
Object.defineProperty(global, totoSymbol, {
enumerable: true,
writable: true,
value: 4,
configurable: true,
});
assert.ok(global[totoSymbol] === 4);
Comment thread
dubzzz marked this conversation as resolved.
Outdated
assert.ok(Object.getOwnPropertySymbols(global).includes(totoSymbol));