fixup! make resource compulsory

nodejs · nodejs-github-bot · Feb 7, 2023 · Feb 4, 2023 · Feb 4, 2023 · Feb 4, 2023
commit 2e41a14fbf2fb63bd9c580374b2f539ca9aca0c0
diff --git a/lib/internal/abort_controller.js b/lib/internal/abort_controller.js
@@ -43,6 +43,7 @@ const {
 const {
   validateUint32,
   validateAbortSignal: abortSignalValidator,
+  validateObject,
 } = require('internal/validators');
 
 const {
@@ -366,8 +367,9 @@ function transferableAbortController() {
  * @param {any} resource
  * @returns {Promise<void>}
  */
-async function aborted(signal, resource = null) {
+async function aborted(signal, resource) {
   abortSignalValidator(signal, 'signal');
+  validateObject(resource, 'resource', { nullable: false, allowFunction: true, allowArray: true });
   if (signal.aborted)
     return PromiseResolve();
   const abortPromise = createDeferredPromise();

diff --git a/test/parallel/test-aborted-util.js b/test/parallel/test-aborted-util.js
@@ -6,15 +6,6 @@ const { aborted } = require('util');
 const assert = require('assert');
 const { getEventListeners } = require('events');
 
-{
-  // Test aborted works
-  const ac = new AbortController();
-  aborted(ac.signal).then(common.mustCall());
-  ac.abort();
-  assert.strictEqual(ac.signal.aborted, true);
-  assert.strictEqual(getEventListeners(ac.signal, 'abort').length, 0);
-}
-
 {
   // Test aborted works when provided a resource
   const ac = new AbortController();
@@ -39,7 +30,15 @@ const { getEventListeners } = require('events');
 {
   // Fails with error if not provided abort signal
   const sig = new EventTarget();
-  assert.rejects(aborted(sig), {
+  assert.rejects(aborted(sig, {}), {
+    name: 'TypeError',
+  });
+}
+
+{
+  // Fails if not provided a resource
+  const ac = new AbortController();
+  assert.rejects(aborted(ac.signal, null), {
     name: 'TypeError',
   });
 }