Skip to content

sea: add support for V8 bytecode-only caching #48191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 27 commits into from
Jul 26, 2023
Merged

sea: add support for V8 bytecode-only caching #48191

Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
18e0a49
sea: add support for V8 bytecode-only caching
RaisinTen May 24, 2023
184e9e6
src: use `std::nullopt` instead of `{}`
RaisinTen May 27, 2023
51cf8c1
src: pass parameters vector by a pointer
RaisinTen May 27, 2023
ae48e90
sea: pass code cache data as an external buffer to JS
RaisinTen May 27, 2023
145335b
sea: fix entry point file name
RaisinTen May 29, 2023
f855bd5
src: use MaybeLocal<Function>() instead of {}
RaisinTen May 30, 2023
f549743
src: use DataView instead of Buffer for code cache
RaisinTen Jun 1, 2023
81f896f
sea: warn if code cache is rejected
RaisinTen Jun 2, 2023
4210887
fixup! sea: warn if code cache is rejected
RaisinTen Jun 2, 2023
e8aa501
src: add TODO for supporting `import()`
RaisinTen Jun 8, 2023
b5b2d78
src: return result of CompileFunction directly
RaisinTen Jun 27, 2023
5cd337f
sea: make code caching optional
RaisinTen Jun 27, 2023
27b9a6c
src: pass length to v8::String::NewFromUtf8() for std::string_views
RaisinTen Jun 27, 2023
c62e892
test: adjust line numbers in test/fixtures/errors/force_colors.snapshot
RaisinTen Jul 3, 2023
1f8f86b
src: use kNoCompileOptions instead of kEagerCompile
RaisinTen Jul 10, 2023
6589352
Apply suggestions from code review
RaisinTen Jul 20, 2023
9fe2f4d
src: pass only the context to CompileFunction
RaisinTen Jul 20, 2023
4020a9f
test: add a comment to explain how unexpected warnings are treated
RaisinTen Jul 20, 2023
72ed49f
src: fix conflicts
RaisinTen Jul 21, 2023
86d3407
doc: run -> compile
RaisinTen Jul 21, 2023
fc9509b
doc: add note about import() not working
RaisinTen Jul 21, 2023
80dbcbf
sea: call getCodePath() only when isSea() is true
RaisinTen Jul 21, 2023
b1792b5
lib: do not load SEA binding for non-SEA code paths
RaisinTen Jul 21, 2023
2a2d12e
src: remove unnecessary HandleScope
RaisinTen Jul 21, 2023
80cd1ff
src: guard against calling sea.getCodePath() in userland
RaisinTen Jul 21, 2023
d44aa0d
src: remove unnecessary HandleScope
RaisinTen Jul 21, 2023
91bf2df
test: fix test/parallel/test-node-output-errors.mjs error
RaisinTen Jul 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: fix test/parallel/test-node-output-errors.mjs error 
Signed-off-by: Darshan Sen <raisinten@gmail.com>
  • Loading branch information
@RaisinTen
RaisinTen committed Jul 21, 2023
commit 91bf2df51c8453eee7364ec3de66ce141fec6d59
8 changes: 4 additions & 4 deletions test/fixtures/errors/force_colors.snapshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ throw new Error('Should include grayed stack trace')

Error: Should include grayed stack trace
at Object.<anonymous> (/test*force_colors.js:1:7)
 at Module._compile (node:internal*modules*cjs*loader:1240:14)
 at Module._extensions..js (node:internal*modules*cjs*loader:1294:10)
 at Module.load (node:internal*modules*cjs*loader:1092:32)
 at Module._load (node:internal*modules*cjs*loader:939:12)
 at Module._compile (node:internal*modules*cjs*loader:1241:14)
 at Module._extensions..js (node:internal*modules*cjs*loader:1295:10)
 at Module.load (node:internal*modules*cjs*loader:1091:32)
 at Module._load (node:internal*modules*cjs*loader:938:12)
 at Function.executeUserEntryPoint [as runMain] (node:internal*modules*run_main:83:12)
 at node:internal*main*run_main_module:23:47

Expand Down