Skip to content

src: remove OnScopeLeaveImpl's move assignment overload #48732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 3 commits into from
Jul 16, 2023
Merged

src: remove OnScopeLeaveImpl's move assignment overload #48732

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32e8396
src: remove OnScopeLeaveImpl's move assignment overload
CGQAQ Jul 11, 2023
e9955e9
src: fix format
CGQAQ Jul 11, 2023
750f797
src: remove unused operator overload
CGQAQ Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
src: remove unused operator overload
  • Loading branch information
@CGQAQ
CGQAQ committed Jul 12, 2023
commit 750f7973d6f0c810e3ca671c1ed9ba56b4383c69
8 changes: 0 additions & 8 deletions src/util.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,14 +577,6 @@ struct OnScopeLeaveImpl {
: fn_(std::move(other.fn_)), active_(other.active_) {
other.active_ = false;
}
OnScopeLeaveImpl& operator=(OnScopeLeaveImpl&& other) {
if (this == &other) return *this;
if (active_) fn_();
fn_ = std::move(other.fn_);
active_ = other.active_;
other.active_ = false;
return *this;
}
};

// Run a function when exiting the current scope. Used like this:
Expand Down