Skip to content

Document require("stream/promises").pipeline end option #48970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 2 commits into from
May 12, 2024
Merged

Document require("stream/promises").pipeline end option #48970

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3f1aec
test: test pipeline `end` on transform streams
aloisklink Jul 30, 2023
ca2f874
doc: document pipeline with `end` option
aloisklink Jul 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: test pipeline end on transform streams 
Add test that confirms that
`stream.promises.pipeline(source, transform, dest, {end: false});`
only skips ending the destination stream.
`{end: false}` should still end any transform streams.

PR-URL: #48970
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
@aloisklink @aduh95
aloisklink authored and aduh95 committed May 12, 2024
commit f3f1aec0962f988c9c04931e58fe95802f426207
6 changes: 5 additions & 1 deletion test/parallel/test-stream-pipeline.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1476,10 +1476,14 @@ const tsp = require('timers/promises');
});

const duplex = new PassThrough();
const transform = new PassThrough();

read.push(null);

await pipelinePromise(read, duplex, { end: false });
await pipelinePromise(read, transform, duplex, { end: false });

assert.strictEqual(transform.destroyed, true);
assert.strictEqual(transform.writableEnded, true);

assert.strictEqual(duplex.destroyed, false);
assert.strictEqual(duplex.writableEnded, false);
Expand Down